Dave Pitts

Results 4 comments of Dave Pitts

Sure @kandersolar I can add the tests to `pvlib/tests/test_spa.py` I see there is already `def test_julian_day_dt(self)` but * This only contains a `single assert_almost_equal` check - which was passing despite...

First, I wrote and tested the extra tests in a pytest separate file. ``` (.venv) ~/projects/pvlib-python bugfix/issue-2077 $ cat tests_issue_2077.py import pvlib import pytest # Define the test cases as...

I have pushed a commit (correct-test-indention-and-class) as requested @kandersolar. Sorry for delay, I was having some issues with my local python venv. Fortunately fixed/rebuilt now and tests working locally again:...

There is also a linter error: ``` Run git diff upstream/$GITHUB_BASE_REF HEAD -- "*.py" | flake8 --exclude pvlib/version.py --ignore E201,E241,E226,W503,W504 --max-line-length 79 --diff Error: pvlib/tests/test_spa.py:430:1: E305 expected 2 blank lines...