Kai Pastor

Okay, you are not really familiar with CMake... In general, it is preferred to use upstream's official build system, not vendor another into the port. Even if it means to...

IMO this still needs a simplification, and the port should be based on (patching) the official CMake build.

I still think that this shouldn't be merged as is: - The new port vendors `CMakeLists.txt` instead of using/patching upstream's `CMakeLists.txt`. - The capstone Find module is redundant. capstone provides...

Hm, I'm still mildly opposed to putting private headers into the main include dir, for one unknown use case. But someone else must decide.

There are two separate questions: - whether to install private headers: upstream. - whether to install particular files directly to `include`: integrator (vcpkg).

This port already has a custom CMakeLists and config. You could easily carry the private interface include dir through another interface target. Making linking to the private target the only...

There is overlap with #44927 wrt wpilib/eigen.

Would it make sense to cherry-pick some port modifications into indidual PRs?

> For now, it’s more convenient for me to make changes in the current one, since it’s not yet clear how many more changes will be required. In my experience,...

I still think it might be beneficial to cherry-pick some updates into individual PRs. I have some comments but I'm hesitating to throw them in.