Kai Pastor

Results 1073 comments of Kai Pastor

> Related issue: #30745 Not related. ~~~ Called: `/bin/pkg-config --modversion cairo` -> 1 stderr: Package xext was not found in the pkg-config search path. Perhaps you should add the directory...

You must click "Ready for review".

#38965 for kf5kio regression.

> The port usage tests pass with the following triplets: > > * x64-windows You must test with a static triplet, due to https://github.com/microsoft/vcpkg/pull/38368#discussion_r1758183614 Also not satisfied with https://github.com/microsoft/vcpkg/pull/38368#discussion_r1753106083

The actual problem with `default.sofa` is the fact that it is a symlink in git and doesn't exist when unpacked on Windows. libmysofa fails to build from source when it...

This is legacy CMake, with all its downsides and exceptions. CMake's Find modules cannot be generalized too much because they use different styles. From general experience: - `_INCLUDE_DIR` (singular) should...

> I think when we are pointing GDAL devs to a template to use to create a **new** driver, we assume that those variables include multiple paths, and when checking...

I guess this still is an issue. And please don't shorten the deadline which is promided by the bot.

- `-dbus-linked` means a hard build time dependency and a visible deployment dependency for shared linkage. I doubt that this is generally desired. - `-dbus=runtime` doesn't have a build time...

One more note: We always build dbus as a shared lib at the moment, even for static triplets.