Kai Pastor

Results 1023 comments of Kai Pastor

> The bot is complaining about deprecated vcpkg cmake functions, but I don't see any left. Do I need the dependency on vcpkg-cmake-config that it suggests? `vcpkg-cmake-config` provides `vcpkg_cmake_config_fixup()` as...

Needs #25862 for windows.

If upstream thinks that `BuildFlatBuffers.cmake` should be used in downstream projects (i.e. is public API), then it would be upstream's task to add a proper install command (and integrate with...

Wouldn't it be enough to add `vcpkg_check_linkage(ONLY_STATIC_LIBRARY)` to the portfile?

> > vcpkg_check_linkage > > How is different than adding 'static' to the supports in the manifest? `static` in `supports` doesn't change the build, it is just declared information. `vcpkg_check_linkage(ONLY_STATIC_LIBRARY)`...

The vcpkg portfile can do everything what is needed to create valid pkg-config files, so that users don't have to use `--static` at all. That's the advantage of strictly using...

Doesn't dpdk currently build in `master`, including x64-linux? If it builds, do we really need to remove or change the patch, or isn't it enough to use the current patch...

I think I managed to update the patch, and I will open a PR. I'm also proposing to drop the unofficial CMake config (multiple anti-patterns) and update `usage` to show...

The CMake config problem might be resolved. But the more serious problem is `/include/OpenEXR`, used by both ports. This will break vcpkg CI as soon as there are consumers for...

> The fatal error on installing both seems reasonable. This is used only as an execption in vcpkg. It excludes one version from CI, and every other port depending on...