Dan Foreman-Mackey

Results 547 comments of Dan Foreman-Mackey

This is great @lgrcia!! I'll take a closer look later. > I did a modification so that beta in their [utils.rotation.generate_rotate_dls](https://astro-informatics.github.io/s2fft/api/utility/rotation.html) can be non-static. Is this something where you could...

Thanks @shashankdholakia! Happy to chat at some point if you're feeling the urge to hack on this :D

Thanks for starting this! My goal is to support at least a significant subset of the `starry` functionality directly within `jaxoplanet` rather than as a separate package. For example, right...

For performance reasons, `starry` needed to include many different compiled "ops". For example, limb darkening needed to be implemented separately from the general starry matrices. In this case, I think...

Thanks for bringing this up! This was one of our top motivations for developing jaxoplanet in the first place and it's absolutely supported. Here we benefit from [`jax.vmap`](https://jax.readthedocs.io/en/latest/jax-101/03-vectorization.html), which means...

Thanks for bringing this up! This is an important use case in mind, and we should make sure that we support it. In principle this is supported by the `Central.from_orbital_properties`,...

Yes - this should absolutely work with the `starry` submodule, since the `SurfaceMapSystem` takes a `Central` object. We should add an appropriate test for this. > Out of curiousity, will...

My only -1 on zeros (vs a literal `None` - I definitely wouldn't recommend Nan!) is that we might end up allocating large arrays of unnecessary zeros which would be...

Thanks for the CC, @mattjj. I have a scheme for handling this more generally soon™, but writing the DCE rule should be straightforward here and I'm also happy to help!

It isn't straightforward because of technical reasons about how the core algorithms are implemented. Depending on your use case you might be able to use [tinygp's quasiseparable solver](https://tinygp.readthedocs.io/en/stable/tutorials/quasisep.html) which is...