Dan Foreman-Mackey

Results 547 comments of Dan Foreman-Mackey

For conda-forge (https://github.com/conda-forge/finufft-split-feedstock) the library and Python bindings are built separately so this is crucial for that. We can keep patching if strictly necessary. On Tue, Jul 23, 2024 at...

@DiamonDinoia Yes that's all good. @janden was suggesting step 2 should be removed, and I was just asking that it not be.

On conda-forge the build is patched so that the Python extension never compiles the core libraries since those are packaged separately.

Thanks for the heads up @DiamonDinoia! I probably won't have a chance to update the conda-forge recipe until after the final version is out, but I'm sure it'll be no...

I've just seen this because Alex mentioned it over on the jax-finufft repo. It's not immediately obvious that this would help the JAX implementation because of JAX's opinions about autodiff,...

There's definitely going to be a lot of overhead in the way the exoplanet version is calculated here. Every time you call `eval` it's recompiling the graph and all the...

Ah - I see. I definitely wouldn't use exoplanet as the baseline for this in this case. I've actually found that there are enough edge cases where the polynomial approximations...

Thanks for asking! The plan is to eventually deprecate the `limb_dark.light_curve()` function once all the `starry`/`Surface` stuff gets moved out of `experimental`. For now, none of the orbits within core...

(Note: I've never used `filter_jit` so I don't know if it has different semantics.) Typically I would include this within a helper function, e.g.: ```python @jax.jit def compute_light_curve(params, time): system...