Dan Foreman-Mackey
Dan Foreman-Mackey
Fixed in #309 and #311
@saimn — Thanks for the kind words! Unfortunately, the situation here is not great. I was nearly ready to merge this (I still needed to run through the case studies...
@saimn — Yeah I think that's what I'd recommend for now if that's ok! Please let me know if you run into issues and I'm happy to help.
@vandalt — Yeah, I think that starting from this PR is probably the right way to go because I made some progress handling the backwards incompatibilities. If you're keen, I'd...
Interesting proposal! I'm not so keen to change these variable names, since the units are consistent across _all_ parameters/arguments of the `KeplerianOrbit`, so we'd need to change all of the...
See [this repo](https://github.com/dfm/fast-astropy-timeseries-binning) for some faster accumulation functions!
Using that C library linked above, I get another order of magnitude speed up on my system! I'll look into contributing that upstream to astropy.
Here are the benchmarks: - on `main` (5.84s): - on `tylerapritchard/replace_aggregate_downsample` (2.82s): - incorporating the (highly incomplete) C library above (164ms):
Ready to review! cc @christinahedges
This looks great too! Can you fix the conflicts and try to see what the pre-commit failure is being caused by? Here is the error log: ```` trim trailing whitespace.................................................Passed...