exoplanet icon indicating copy to clipboard operation
exoplanet copied to clipboard

Conflicts with current version of arviz/xarray

Open gjgilbert opened this issue 1 year ago • 3 comments

Describe the bug In a clean conda environment, exoplanet fails to import, raising two dozen or so traceback errors leading through exoplanet --> pymc3 --> arviz --> xarray.

Forcing xarray==2022.9.0 fixes the issue, and also sets arviz==0.12.1

To Reproduce In terminal:

conda create --name test1
conda activate test1
python -m pip install -U exoplanet

In python: import exoplanet

Expected behavior Exoplanet should work on pip installation.

Inside the clean conda environment, running

python -m pip install -U exoplanet
pip install xarray==2022.9.0

seems to fix the issue

Your setup (please complete the following information):

  • Version of exoplanet: 0.5.3
  • Operating system: macOS 12.1 (M1 chip)
  • Python version & installation method (pip, conda, etc.): python=3.9, virtual environment created with conda, pip install everything else

Additional context I think the root issue is conflicting numpy requirements, but I haven't investigated any further.

gjgilbert avatar Nov 28 '23 21:11 gjgilbert

Thanks! We've fixed this in a few places, but it hasn't been propagated to exoplanet yet. Over in #309, it's fixed using the following requirements:

"pymc3>=3.9", "numpy<1.22", "xarray<2023.10.0"

Would you be willing to open a PR to the main branch adding a constraint like this so that we can release an update sooner?

dfm avatar Nov 28 '23 22:11 dfm

Opened a PR #311. In the future for small issues such as this would it be better to make a PR directly rather than opening an issue?

gjgilbert avatar Nov 29 '23 15:11 gjgilbert

Thank you!! Either way is totally fine with me. Small PRs are the absolute best, but issues are also useful for tracking. Whichever is best for you! Thanks again!

dfm avatar Nov 29 '23 15:11 dfm

Fixed in #309 and #311

dfm avatar Apr 16 '24 15:04 dfm