Dan Foreman-Mackey
Dan Foreman-Mackey
Thanks for this contribution! I'm totally swamped right now, but I'll try to take a closer look at this ASAP.
The project should be installed into the environment before running `sphinx-build`. This will be better than the path hack, because we want to make sure `setuptools_scm` runs to get the...
> As I wrote that 3 lines patch allows to do generate documentation without that requirement. Right, and as I explained above, it doesn't work as expected and you'll get...
That's because you _previously_ ran an install. If you do a fresh checkout and run your patched version, it won't work, I promise!
Right, you're running `build` first, not `install`, my bad!
Good - sorry for the quick close! Re-opening wrt to the main issue reported here.
Thanks! That `DeprecationWarning` is expected (it's testing backwards compatibility) and has been happening since v3.0 🤦 We should catch it and silence it! Otherwise, things look fine to me.
@editorialbot assign me as editor Thanks all for you patience! I'm happy to edit this submission and I'll start looking for reviewers shortly.
@editorialbot add @ideasrule as reviewer 🎉 Thanks @ideasrule for agreeing to review this submission! As soon as we have a second reviewer lined up I'll get the main review thread...
@editorialbot add @LorenzoMugnai as reviewer 🎉 Thanks @LorenzoMugnai for agreeing to review this submission!! I'll get the main review started in a new thread and have lots more info for...