dfinkel
dfinkel
You didn't miss an obvious way to handle this. Generally, we haven't exposed this data because tracing generally provides a better view and it's pretty rare that you'd want that...
FWIW, my team switched our bufconn uses to `localhost` as the address, since that's guaranteed to resolve with the DNS resolver.
Thanks @rahul2393 for the prompt review and approval! Sorry about the test failures! It looks like an `else if` block got lost while I was cleaning up the commits before...
Friendly ping @rahul2393 (thanks for the prompt approval)
@rahul2393 if you have a few minutes, can you make another pass over this PR?
Thanks @rahul2393 !
Thanks @apstndb, I definitely copied those cases from the documentation. I can put together a PR to switch those to something that's actually valid tomorrow. (I think I meant to...
I just opened a PR with fixes for some bugs I ran into while using the features in this PR (including fixing the tests that @apstndb pointed out): https://github.com/googleapis/google-cloud-go/pull/11279 The...
I've filed #10945 to cover this. (As usual) I'm open to revisions/feedback. I mostly tried to follow the local style, but probably deviated in a few places.
The review on #10945 seems to have gone silent after I fixed a bug from a bad rebase/merge conflict. Would it be possible for someone to make another pass over...