google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard
verified publisher icon googleapis

spanner/spansql: support for Protobuf column-types

Open dfinkel opened this issue 1 year ago • 1 comments

Client

Spanner

Environment

any

Code

I'll open a PR shortly adding support to the spansql package for parsing/canonicalizing protobuf types, and adding support for CREATE/ALTER/DROP PROTO BUNDLE statements.

dfinkel avatar Oct 02 '24 14:10 dfinkel

I've filed #10945 to cover this.

(As usual) I'm open to revisions/feedback. I mostly tried to follow the local style, but probably deviated in a few places.

dfinkel avatar Oct 02 '24 14:10 dfinkel

The review on #10945 seems to have gone silent after I fixed a bug from a bad rebase/merge conflict. Would it be possible for someone to make another pass over that PR? Thanks!

dfinkel avatar Oct 31 '24 18:10 dfinkel