David Ellis

Results 212 comments of David Ellis

> Also other thing that was not covered will be the organization of modules inside code. Howe are we going to group them? Will it make sense at this point...

> Only adding a typo comment for now. I think I need some time to think about the proposed options. If we adopt one of these four as-is, I would...

https://github.com/iasql/iasql-engine/runs/8211468751?check_suite_focus=true#step:6:24418 Oops. Fixing that.

Agreed with @isaacbrodsky. A combination of DGGRID being C and Rust being much less mature 6-7 years ago is why we went with C. We intentionally went with a memory...

The same behavior on my end: ``` damocles@Talyn:~/oss/h3-node(master)$ node Welcome to Node.js v14.15.4. Type ".help" for more information. > const h3 = require('./') undefined > h3.polyfill([[-142, 55], [-115, 75]], 4)...

From the perspective of the polyfill algorithm, it joins the last point to the first point and creates two segments that overlap, then it traces those segments to create boundary...

Options 2 and 3 could be benchmarked versus baseline to see if the impact is significant either way. Option 3 feels like the best option, since it wouldn't require a...

> So far this looks like a problem in the underlying h3 library where `polygonToCells` returns E_FAILED. I'll put together a C testcase and report an issue against the library;...

To answer your exact question if there are efforts on that, yes, there is the unstable vectorization API: https://github.com/uber/h3-py/blob/master/src/h3/unstable/vect.py backed by Cython code: https://github.com/uber/h3-py/blob/master/src/h3/_cy/unstable_vect.pyx It does not vectorize the particular...

> Specifically, I'm guessing that `h3_to_geo_boundary` creates a different number of coordinates depending on whether the input is a pentagon (5 output coords) or a hexagon (6 output coords). In...