Doug Fawley

Results 506 comments of Doug Fawley

> I believe you can get roughly that behaviour at the moment by calling grpc.SetSendCompressor("identity") within a handler or an interceptor. `SetSendCompressor` does not allow you to toggle it per...

As discussed offline, I am weary to add 20 lines to this already long document. Maybe we can solve our problems by providing a better template that includes the fields...

> The stream can be promptly terminated via the cancelable context mentioned I'm not sure about this one. How do you propagate the context cancellation to the stream itself so...

> I could probably inspect how the low level grpc layer is able to terminate the stream promptly. I'm fairly certain your application isn't blocked on flow control if that's...

I don't think we need any further information here in order to implement the proposal above ("Add a method to invoke RST_STREAM to [ServerTransportStream](https://pkg.go.dev/google.golang.org/grpc#ServerTransportStream)"). But we don't have the resources...

I filed https://github.com/protocolbuffers/protobuf/issues/23057 for the protobuf team to address this. We can leave this open as a reminder to remove the workaround.

FYI protocolbuffers/protobuf#23057 was marked as fixed. I'm not sure if we need to wait for a release or what.

I'd really like to wrap this up before we cut the release branch. Will that be possible?

> @arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again? _This_ PR affects codegen, so it should regenerate everything regardless.

We've considered task local storage before for this kind of thing in the past. That makes propagation implicit, which not quite as good as being explicit IMO. It does match...