Daniel Farrell

Results 16 comments of Daniel Farrell

I think there may be consensus that mixed tabs and spaces are not good. Agree that it would useful for enforcing consistent style in large projects.

We ended up adding a check like `! grep $$'\t'` to our shellcheck Make target to have this feature. https://github.com/submariner-io/shipyard/pull/835/files#diff-45f338d2aca0e170b4531d9554b6a2a0ad301a651de3a0c237af4365dabbf2ffR199

Hey @amye! Thanks for checking in, be assured we're working to get everything done. We're maintaing details about our progress on https://github.com/submariner-io/submariner/issues/1297. A few things we can check off I...

I think we can also check these off, as we have a critical mass of the committers [signed-off as understanding them](https://github.com/submariner-io/submariner/issues/1297#issue-871240851): - [x] Understand the project proposal process and reqs:...

> Quick check in here, artwork? Yeah, that's one of the last ones still fully TODO, not in review. Was just slowly poking at gimp trying to make it happen....

Thank you, that would be a huge help! This is the SVG I was basing everything on: https://submariner.io/images/logo-submariner.svg And sampling a logo in gimp, I get the color code `2bdfc4`...

I think we can now check off: - [x] Ensure your project meets the CNCF IP Policy: https://github.com/cncf/foundation/blob/master/charter.md#11-ip-policy - Details in @skitt's [comment above](https://github.com/cncf/toc/issues/649#issuecomment-847834145) - [x] Website: ensure LF footer...

Maybe better just to remove the docs on specific ODL/OS versions and just tell user how to find currently supported boxes via vagrant status. Should require less maintenance.

It's much harder to help support raw CBench usage/errors than WCBench errors (especially using the Vagrant env) because your configuration is largely unknown. The initial driver for creating WCBench was...

> I would be interested in this. Wonderful! :+1: > Do you have some kind of API in mind? Here are some initial thoughts. - `install_odl [verbose]` - `install_cbench [verbose]`...