Christoph Berg

PG 16 is out, any chance to get this fixed?

Added missing `#include ` in security.c now.

I was googling around and found like half a dozen different answers. Will give this one a shot now.

Sorry the commit where I had tried `HAVE_OSX` had a silly typo elsewhere. But it looks like `__APPLE__` worked, and it found the header, but `htobe32` is still not available.

I believe my patch is correct, but MacOS lacks the modern `htobe*` functions.

Hi, it was a hard failure here, perhaps in conjunction with stricter compiler flags on Debian unstable. Will check again tomorrow, too late now to dig up build logs.

Here's the error message without the patch, PG 16.0 on Debian unstable/amd64. clang means this step happens when compiling the .bc files for JIT support: ``` make[1]: Entering directory '/home/myon/projects/postgresql/rdkit/rdkit/build-16'...

... right, gcc is also raising warnings (but not errors): ``` /home/myon/projects/postgresql/rdkit/rdkit/Code/PgSQL/rdkit/mol_op.c: In function ‘mol_murckoscaffold’: /home/myon/projects/postgresql/rdkit/rdkit/Code/PgSQL/rdkit/mol_op.c:343:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 343 | CROMol scaffold =...

@rvianello sorry I can't see that "small PR", where is it? I rebased my pg16 branch, it still applied cleanly, and added the changes to bfp_gist.c:657,659 and rdkit_gist:549,550.

@greglandrum ^