Jeon Suyeol

Results 172 comments of Jeon Suyeol

We can set deployment version by providing a xcconfig and bundle version by modifying an Info.plist. Currently I'm archiving SPM generated xcodeproj as following: * https://github.com/ReactorKit/ReactorKit/blob/0.4.5/.travis.yml#L38-L46 * https://github.com/ReactorKit/ReactorKit/blob/0.5.0/scripts/carthage_helper.rb I think...

I'm having busy days and don't have enough time for this issue at time time. I'll update this PR when I'm available :)

Hey guys, I've created a PR(#1945) for this. I hope you guys could review my PR. Thanks!

Same here. VSCode doesn't complain about it but mypy CLI does. `Field` imported from `ninja`. What a weird behavior... - VSCode - mypy CLI

Using emoji is REALLY cool!

@MeGaPk, I'm not sure what you want. Can you add some more explanations?

Which version of ruby are you using? POEditor requires at least Ruby 2.1. (I just added a ruby requirement to gemspec.)

@kmiloaguilar, Thanks for your work. Could you please separate the core implementation? There're lot of unreleated diffs.

I mean, 1 PR (or 1 commit) should have 1 implementation. Your PR has only a commit that contains 'Adding an increase & decrease rate for the button' and 'fixing...