SSBouncyButton icon indicating copy to clipboard operation
SSBouncyButton copied to clipboard

Published 20 hours ago • verified publisher icon StyleShare

Adding an increase & decrease rate for the button, fixing demo and project settings

Open kmiloaguilar opened this issue 8 years ago • 6 comments

kmiloaguilar avatar Jul 28 '16 02:07 kmiloaguilar

@kmiloaguilar, Thanks for your work. Could you please separate the core implementation? There're lot of unreleated diffs.

devxoul avatar Jul 28 '16 09:07 devxoul

@devxoul Can you me more specific? How do you prefer to separate with core implementation? For now the new properties if they are not set it will still do the same. The Pod folder I removed all since not required over here. And the Demo is the only one. I could create a separate buttons for the demo if that is the separation you want.

kmiloaguilar avatar Jul 28 '16 12:07 kmiloaguilar

Also the Demo was failing when doing a clean install, mostly because of the Pods. Adding instructions to run pod install can help too.

kmiloaguilar avatar Jul 28 '16 12:07 kmiloaguilar

I mean, 1 PR (or 1 commit) should have 1 implementation. Your PR has only a commit that contains 'Adding an increase & decrease rate for the button' and 'fixing demo and project settings'.

devxoul avatar Jul 28 '16 14:07 devxoul

ok so you want 1 PR for adding new properties to the button and another PR to fix the demo and project settings ?

kmiloaguilar avatar Jul 28 '16 14:07 kmiloaguilar

@kmiloaguilar Exactly! Thanks for your understanding to keep commit & PR log clean :smile:

devxoul avatar Jul 28 '16 15:07 devxoul