Devon Govett

Results 894 comments of Devon Govett

> With asChild you do not need to implement complex type inference asChild is not type safe, that's why it seems simpler. You can put any component in there even...

> I feel that asChild has the same level of type safety as as prop. In TypeScript you can't really specify the types of React children. [Here's an example](https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAJQKYEMDGMA0cDeaA2EAdkgKL5IhJFaKobmXUwC+cAZlBCHAORT0YvANwAoUcBpIo7dEjgAFFAJoKuYAM65RcXXDQALYPgAmKgFx10MRlRoAeAOIQIJgMJHTaiJoB8olnFJGGlZNHlnVw9jE29NbT0OFwB+Sw0YKEkAc0SAoKkZOTgAIRR3T1j1LRwdPXYUyyIAVxAAI2k80XYmogxgYkVlZgAKMCrLJRUYOI0ASgS9ARgmqCJ9QhJbEbGfDQA6QxiVbBx6iEteEPTeFnm9Tu7emH61yPKY0fG4N+ivKvmaoklis1vYTMAAG5wAD0-kCXR6fQGpXepk+u0sKN+lV2ANqumBqzgYMhMLh4keSLWpAAHihwBRhnigUhlkThvjEsT-FzecTJsxfE4XKiTGT7NCBTQeXzEvYpTAhViKuLJUNpZy5bDObMAkA). As...

We should consult the globalization team on this. I believe they might have raised something similar in the past as well. Even if the language of the website content is...

Hey all, sorry for the delay. After consulting with our globalization team, we decided not to make a change here. They pointed out that there is actually already a discrepancy...

We did not include keyboard interactions in `useLongPress` by default because they often differ between components. For example, in a button with both normal and long press mouse/touch interactions, you...

Then you wouldn't be able to perform actions like add comments/reactions/close issues/etc

Yeah at the moment it just treats the glob as bytes. I think we could probably do this in a way that isn't too perf intensive. For example treating the...

Thanks! It's still sorta WIP, so I haven't had time to do any fuzzing myself just yet. Will take a look soon.

Fixed some bugs in d19fb3da6af38d8757e5d31200e0e95d02a84ecf which seems to have improved performance on your example patterns by a lot. If you find more, or want to share the program you used...

Sure a cargo fuzz setup sounds good if you feel like it. Thanks!