Devon Govett

Results 894 comments of Devon Govett

> the same traps could be placed around portals Yeah that's possible, but I don't think it's a good idea for react to be inserting extra DOM nodes for you...

@AlmeroSteyn > There are also cases where the popup is not modal. A menu is a perfect example. Yeah, and in that case you wouldn't use the `lock` prop on...

Imagine a dialog. It contains some inputs. ```jsx function Dialog() { return ( ); } ``` If input 1 is focused, and a user then clicks outside either of the...

> I think we have different expectations of behavior for a focus trap. Ah I see. The [aria practices spec for modals](https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html) says that focus should cycle within the modal,...

@jessebeach thanks for your feedback! I'm less concerned about developers needing to specify a custom focus order to React, though that could certainly be revisited, but how React itself can...

On further thought, I suppose handling the Tab key in React wouldn't be too bad. If other platforms move focus around without firing a Tab key event, React simply wouldn't...

Sentenel elements are a dead end for react core since they would require React to change the DOM structure from what the user specified. That could have strange consequences for...

I also maintain the `brotli` package. If you'd like to add support for brotli to browserify-zlib using a dependency on the `brotli` package, it would be a welcome PR! The...

Seems fairly safe now, except for IE 11: https://caniuse.com/#feat=wasm. I'd happily accept PRs to fix the browser issues in `brotli`. A WASM compiled version would also be greatly appreciated.

Also, I'm planning on transferring this repo to the `browserify` organization on GitHub so more maintainers can work on browserify-zlib.