David CARLIER
David CARLIER
> The main thing I see missing here is a use of `ethhdr`. A struct type with no usage by libc might not actually belong here, even though it is...
> The definitions look correct to me, but they're awfully obscure. These constants are so obscure that there's a risk of them being deemed unstable private APIs. That's why I...
I would suggest to submit a PR, makes sense.
WIll have a look soon-ish. Not 100% sure it really comes from this commit, if I comment the whole FreeBSD block the test still fail the same way.
for the time being, need to add those constants as exception (for CI), as if musl then ignore those two.
nice, it might be best to create a PR for this musl update alone tough. cc @tgross35
You re in the luck, seems [it is already there](https://github.com/rust-lang/libc/blob/libc-0.2/src/unix/bsd/netbsdlike/mod.rs#L504).
> I think this looks good, but can you confirm that `fanotify_event_info_pidfd` and `fanotify_event_info_error` are GNU-only? Also needs a rebase. yes I confirm no presence in other libcs
@rustbot review