David Widmann

Results 1463 comments of David Widmann

I've seen it in multiple repos but I've never spent time trying to figure why the action is broken in some repos and works in others.

For instance, it errors also in the ForwardDiff repo (https://github.com/JuliaDiff/ForwardDiff.jl/pull/665) and AbstractFFTs (https://github.com/JuliaMath/AbstractFFTs.jl/pull/121).

I agree mostly, I think. Basically, as eg. mentioned in some other issues, my take is that I think AbstractDifferentiation should provide 1) a consistent interface for AD systems and...

It's a bit unclear to me in which scenarios this integration would be helpful. Naively, to me it seems if a package supports only `ADType.jl` then generally even with such...

IMO the curried form would be nice, mainly since as mentioned above it would make it possible to fix a backend in a straightforward way without having to create anonymous...

In DistributionsAD we introduced a custom way to specify mappings from R^n to the desired subspace to avoid these issues in our tests (see, e.g., https://github.com/TuringLang/DistributionsAD.jl/blob/d5a479acc90acd9fe42f1abd207788c164ac85af/test/ad/distributions.jl#L252)

Related: https://github.com/JuliaDiff/AbstractDifferentiation.jl/issues/13

> How about this (if the Distributions maintainers are Ok with it): > > * We add `domain` and `support` here, DomainSets owns them. > > * Distributions adds support...

> If there are conflicts with other packages that export this symbol, it would make more sense to only import the specific elements you need, no? Sure, KernelFunctions does not...

> I think that to begin a feature parity with MCMCChains.jl with Plots.jl would be awesome. Since MCMCChains already supports the Tables interface on which AoG is based (see https://github.com/TuringLang/MCMCChains.jl/issues/306#issuecomment-877480205),...