David Widmann

Results 1463 comments of David Widmann

> How would you spot if there is one SArray among the Vararg? I'd define something like ```julia # It would be safer to use `false` as the default fallback......

I'm sure up to a certain extent 😄 But I haven't tested it. IIRC sometimes one can help the compiler by defining such checks recursively. And if the checks only...

Are you sure that these are caused by AbstractDifferentiation? Was the AbstractDifferentiation update the only change compared with e.g. runs on the master branch? I wonder because, e.g., the latest...

Did you actually check type stability? Or is it just a general comment that there could be issues?

Did you try the master branch? Hopefully the recent simplifications already improved things.

> Tangent{Struct}(;x=NoTangent(), y=one(T)) Did you try `Tangent{typeof(mystruct)}(; y=randn(T))` or similar as well (ie without specifying `x`)?

Duplicate of https://github.com/JuliaDiff/AbstractDifferentiation.jl/issues/13, or at least https://github.com/JuliaDiff/AbstractDifferentiation.jl/issues/13#issuecomment-1664642912 and the following discussion?

BTW, regarding > Why is AD.jacobian so central to AbstractDifferentiation.jl and why does it have to be generated via a macro? Can't it be implemented in a more generic way...

> While Julia functions may take multiple inputs, no Julia function returns multiple outputs. Instead, they might return a tuple of outputs. The (co)tangent of a tuple is like a...

@ranocha the action seems to error, do you know what's the problem?