Vladimir Mitrovic

Results 8 comments of Vladimir Mitrovic

From my point of view Solution 1: For versioned routers, calling the enrich_swagger() method from add_header_versioned_routers() is not optimal, because this method is called through a loop from generate_and_include_versioned_routers() for...

Also when think about refactoring, separating the enrich_swagger() method for unversioned and versioned routers can also be an option, because for each versioned router, the logic for unversioned routers is...

Ohh, no, no, sorry for the previous ramblings... this can be solved by registering the startup event through Cadwyn.__init__(), under self.router:... you just need to add self.add_event_handler("startup", self.enrich_swagger). This way,...

@zmievsa do you want me to work on it? Just explain me briefly or open an issue? I pointed out for lifespan behavior while I was working on tests, but...

Yes, let's try again. I have time... and I think I have an idea...

@zmievsa please go ahead with this, some work has jumped in and I've slowed down. Your idea sounds good!

@zmievsa My idea was to implement a custom include_router() method on the Cadwyn class, and to make enrich_swagger deprecated as well as generate_and_include_versioned_routers() and add_unversioned_routers(), so that there is only...

I would like, because I was already working on verselect optimization until I realized that Cadwyn is actually the main project that makes sense. Here is my version of verselect...