Wang Kai
Wang Kai
Hi guys, please help validate the PR.
> I have `EP_HIGH_DPI=false`-related issues in Web, too. > Does anybody know what exactly EP_HIGH_DPI is supposed to do? Just searched around in `ThirdParty/SDL` folder - ``` Mac OS X:...
This seems to be critical - ``` SDL_WINDOW_ALLOW_HIGHDPI = 0x00002000, /**< window should be created in high-DPI mode if supported. On macOS NSHighResolutionCapable must be set true in the application's...
This is how InputScale is set - https://github.com/urho3d/Urho3D/blob/84913ce65b3aa0b8704a2e155d15e196dc572bdb/Source/Urho3D/Input/Input.cpp#L2422-L2432 To me, it the `Input::inputScale_` is High DPI awared, but **UI scale is just not.** In Editor's code, UI scale is set...
There is some potential problematic place - https://github.com/urho3d/Urho3D/blob/84913ce65b3aa0b8704a2e155d15e196dc572bdb/Source/Urho3D/Graphics/OpenGL/OGLGraphics.cpp#L407-L410 Seems conflicts with: https://github.com/urho3d/Urho3D/blob/84913ce65b3aa0b8704a2e155d15e196dc572bdb/Source/ThirdParty/SDL/src/video/emscripten/SDL_emscriptenevents.c#L575
And also, the file watching does not know file creation or file deletion (#2299).
The implementations in Windows/MacOS/Linux are not consistent. **Windows:** https://github.com/urho3d/Urho3D/blob/6dfb25159f9b6020a0c5273d26e797820a8fbb4b/Source/Urho3D/IO/FileWatcher.cpp#L250 https://github.com/urho3d/Urho3D/blob/6dfb25159f9b6020a0c5273d26e797820a8fbb4b/Source/Urho3D/IO/FileWatcher.cpp#L262 **Linux:** https://github.com/urho3d/Urho3D/blob/6dfb25159f9b6020a0c5273d26e797820a8fbb4b/Source/Urho3D/IO/FileWatcher.cpp#L116 https://github.com/urho3d/Urho3D/blob/6dfb25159f9b6020a0c5273d26e797820a8fbb4b/Source/Urho3D/IO/FileWatcher.cpp#L298 **MacOS:** https://github.com/urho3d/Urho3D/blob/6dfb25159f9b6020a0c5273d26e797820a8fbb4b/Source/Urho3D/IO/FileWatcher.cpp#L314 https://github.com/urho3d/Urho3D/blob/6dfb25159f9b6020a0c5273d26e797820a8fbb4b/Source/Urho3D/IO/MacFileWatcher.m#L136
I don't have other platform for testing on hand. According to the implementations, I think the event support table should be like this - | | File Modified | File...
@weitjong Thanks for the explaination! For Windows platforms, I have fixed file added/deleted watching and added an optional directory watching - https://github.com/SuperWangKai/Urho3D/commit/a3fed18f89908a415cd1c2b7fce0eb3217984b76 I think for Linux and MacOS, we only...
The design decision I'm thinking about is that, the file watching for `ResourceCache` was designed for **`autoReloadResources`**, just as the name indicates. In this case, **"File Created"** is not an...