Devin Rhode
Devin Rhode
Just one line of code to turn off: ``` TraceKit.collectWindowErrors = false; ```
Yeah we should have a function like `jQuery.noConflict()`, which is actually pretty easy to implement and I could get to next time I'm working on some commits. The hardest thing...
We collect window errors by default, but I proposed a new handler here in #21 (Could someone close this issue?)
That is correct, the statement could be removed and nothing would change. Good catch!
Hey @joshuap I just wrote this up quick, can you throw it in Honeybadger and make sure all basic functionality is still in tact? @gaiottino, in your window.onerror functon, you'll...
Perhaps a better api would be more like: ``` javascript window.onerror = function(a,b,c) { ... this.notifyHandlers(); }; ``` The `this` would be modified so no global pollution occurs. Actually, since...
@gaiottino and @joshuap, docs on new api here: https://github.com/devinrhode2/TraceKit/blob/patch-5/README.md#existing-windowonerror-function Again, I just wrote this up quickly, so please grab the tracekit.js file here: https://github.com/devinrhode2/TraceKit/blob/patch-5/tracekit.js test it. Let me know how...
Do you have any suggestions on what the api would look like? I think the 4th parameter works well in this case.. this.notifyHandlers is interesting, but this is the global...
Passing the function as a 4th arg is a better api, just have to find a little time to code it up now :) On Jul 29, 2013 5:03 AM,...