Devin Rhode

Just verified. It's good. Pretty sure there should be no merge conflicts also ;)

This is because the error is not being caught anywhere and instead hitting the window.onerror handler.. but I might know a way to actually get the full stack trace in...

Indeed, the behavior is to get a full stack trace, you need to properly throw an error like this: `throw new Error('oops')` 1. Always try to `catch` errors instead of...

Actually, I won't be doing this patch because I can't actually get stack trace info from where you `throw "error"` - therefore in our readme/guide we need to note to...

> 1. Always try to `catch` errors instead of letting them hit the > window.onerror handler. Once they hit the onerror handler, there's no real > stack trace we can...

All javascript code should be wrapped in this: ``` javascript (function(){ //code }).wrapInTryCatch()(); ``` instead of just: ``` javascript (function(){ //code })(); ```

Note: I could also hijack all function `.call`s to be run in a TraceKit try/catch wrapper, but I'm not sure if that's a good idea because it's kind of intrusive....

For browsers supporting a stack property, something like this could be done I think: ``` javascript jsonErrorReport.stack = (new Error('force-added stack trace!').stack; ``` Also, I'm not sure every bit of...

@occ that's a really good idea for `onerror` does this fall under the DOM API standard? What exact standards group would discuss this addition to browsers? -Devin http://zerply.com/DevinRhode2 http://zerply.com/devinrhode2 On...

I've been working on TraceKit for awhile and was also puzzled by this, similarly thinking there must be a good reason that it's being done.. From the first commit ever:...