devanathan-vaithiyanathan

Results 25 comments of devanathan-vaithiyanathan

> Pending test snapshots on Mac and Windows. ![image](https://private-user-images.githubusercontent.com/6755973/454383167-81202711-900f-486d-ada6-2a15758b114d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDk3MzQ0MDcsIm5iZiI6MTc0OTczNDEwNywicGF0aCI6Ii82NzU1OTczLzQ1NDM4MzE2Ny04MTIwMjcxMS05MDBmLTQ4NmQtYWRhNi0yYTE1NzU4YjExNGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDYxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA2MTJUMTMxNTA3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzQ1NDBjOTFiMThlZTA2ZjY2YjBlMDE5MTlmMGRkM2JiOTM0NTQyMjI3NzdhNmQ5OTIwY2RjZDhkZTg4YTkyMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.UJifjj4iR1HO4gcrkzpX1fHIdX0pNrLMRDvZg3lLN00) @jsuarezruiz , pending snapshots has been added.

I have created a [PR](https://github.com/dotnet/maui/pull/29527) for this issue to include additional logic for maintaining the current item when the loop value changes, and to handle scrollbar visibility based on the...

Hi @PureWeen , I've added the missing screenshot for the VerifyGreyShades test case. I think the test will pass now.

> All Android Views have a method `OnConfigurationChanged` that you can override which will fire when the theme changes. I think instead of having to wire this up inside controls...

> @devanathan-vaithiyanathan Could you rebase to fix the conflicts? I have rebased the branch and resolved the conflicts

> > It looks like the device tests on windows are crashing. > > On CI you can check the logs here to see where it's crashing > > ![image](https://private-user-images.githubusercontent.com/5375137/373412564-1e8ad1a1-871d-42af-a58b-b83f7d1b6a2a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjgwMzQyNjcsIm5iZiI6MTcyODAzMzk2NywicGF0aCI6Ii81Mzc1MTM3LzM3MzQxMjU2NC0xZThhZDFhMS04NzFkLTQyYWYtYTU4Yi1iODNmN2QxYjZhMmEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTAwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEwMDRUMDkyNjA3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWE3ZTkxYjJhZDZiMDg2NTA2MGFhOTRlMjMxOGNiMmM4Nzg3YjY2MWMxODYxNzMzMjM3MjdlNTgwMjZhOTU4OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.T1Ti5ZRGFdM_GhJqU4kx3L7sIVyNGObFb-F2lZxZ1ds)...

> > > It looks like the device tests on windows are crashing. > > > On CI you can check the logs here to see where it's crashing >...

> Could review the failing test? I reviewed the failing test case by running it on our machine, and it seems to be running fine.