dev590t

Results 34 comments of dev590t

@XiaoYangLiu-FinRL If I understood the code correctly,ElegantRL is used in DRL step. I mean use Numba in preprocessing data step, like here: ``` data = DP.clean_data(data) data = DP.add_technical_indicator(data, INDICATORS)...

Unfortunaly, I'm not a python data scientist programmer, and have never used Numba. I have discover this lib from the trading lib vectorbt. vectorbt can also preprocess data. I think...

I think it is better to test in first existing GPU trading indicator librairy before to decide to reimplement or no the preprocessing step with Numba or Cupy. And if...

If I understand correctly the interface of Finrl, Finrl can directly use the data from other libraries. During preprocessing step: For classic Talib indicator, Finrl can use the subset of...

@Ron-27 > For some reason when installing vectorbt it installs earlier version of PyYAML vectorbt still use alpaca-trade-api 1.4, that maybe explain why it install earlier version of pyyaml. >...

In https://github.com/ta4j/ta4j/blob/369cadd448df3935745f96c5e5c0b712ad0a96c6/ta4j-core/src/main/java/org/ta4j/core/analysis/criteria/ReturnOverMaxDrawdownCriterion.java#L60 I think we should replace by ``` final Num totalProfit = grossReturnCriterion.calculate(series, tradingRecord) - 1; ```

I think a better solution could be add a new indicator GrossReturnPercentCriterion such as `GrossReturnPercentCriterion = GrossReturnCriterion - 1` And replace https://github.com/ta4j/ta4j/blob/369cadd448df3935745f96c5e5c0b712ad0a96c6/ta4j-core/src/main/java/org/ta4j/core/analysis/criteria/ReturnOverMaxDrawdownCriterion.java#L60 by ``` final Num totalProfit = grossReturnPercentCriterion.calculate(series, tradingRecord)...

I use doom emacs. It use a different mecanism to add package than classic emacs. After reconfigure `~/.doom.d/init.el` with `(python +lsp +pyright +pyenv +poetry +cython) `. And install the packages...

`47degrees/github4s` isn't heavy maintained in this moment I feel, maybe generate all endpoints as you have proposed in #444 is a good solution for the maintenance.

I see many solution. @BenFradet @dcsobral It is possible to make a PR to integrate one into the project?