Khushboo
Khushboo
Currently `AbstractDataType` has 2 variants for sequence/scalar types(i.e. wrapped vs non-wrapped). The non-wrapped variant here is always generated as nested part of some other class and might not require to...
*Issue #, if available:* *Description of changes:* This PR removes the previous implementation for location calculation in text buffer. It also removes feature flag `lazy-source-location` since the current implementation for...
> This branch is not used for `IonSlice`, right? That suggests to me that things aren't encapsulated the right way. It doesn't necessarily need to be addressed now, but this...
*Issue #909* *Description of changes:* This PR works on adding support for location metadata in `LazyValue` API. *List of changes:* - Modifies top level matching logic in buffer to preserve...
Location metadata here means row and column values for the current text input of the buffer. It will be based on the `offset` value currently stored in the buffer and...
Location metadata can be pulled up to `LazyValue` from the underlying buffer. For binary implementations this will be `None` and for text implementations it will come from `TextBuffer::row()` and `TextBuffer::column()`....
Latest version of `winnow` doesn't seem to work with current implementation. Here are the clippy warnings: https://github.com/amazon-ion/ion-rust/pull/905/checks?check_run_id=37060738126. Update to latest version of [winnow](https://docs.rs/winnow/latest/winnow/index.html)
This is a follow-up issue on https://github.com/winnow-rs/winnow/discussions/742 Current approach in `TextBuffer` uses the `reset` API to preserve row and column information. Although `reset` is currently being used in lot of...
### Purpose: Customers that use Ion Rust’s `Element` API to manipulate Ion data can benefit from having more precise row-column information regarding the element. This helps identify the exact place...
Tried following test with `ion-js` which fails with tripple quoted string/long string ```javascript let s: Value = load("'''hello'''''' world'''")!; assert.equal(IonTypes.STRING, s.getType()); assert.equal(s.stringValue(),"hello world"); ``` `s.stringValue()` returns `helloorld`. Further more when...