ion-rust
ion-rust copied to clipboard
Removes location calculation from buffer and feature flag
Issue #, if available:
Description of changes:
This PR removes the previous implementation for location calculation in text buffer. It also removes feature flag lazy-source-location since the current implementation for location shows performance as close to main branch.
List of changes:
- Removed all implementation of location calculation in text buffer.
- Removed
lazy-source-locationfeature flag from current implementation. The performance for lazy /current approach is close to the main branch(~2% regression to main branch, only for scanning data, for reads same performance)
Benchmarks: Lazy Bookkeeping on Flushes (compared to old text buffer solution (#922))
- Significant performance improvements over previous implementation of location support
- Scan operations: ~17% improvement
- Read operations: ~15-16% improvement
- Read 'format' field: ~16-17% improvement
- Performance nearly matching main branch across all operations
The full benchmark result can be found here
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.