Julian Weiland
Julian Weiland
@AndrewLee0 you can use FoundationPress now. It should be possible to update to a new build process later although you don't have to if you don't want to change. Because...
@JPOak that really looks good. I will try try you Webpack implementation in the next days. @kLOsk I'm not very happy with the current build process because it uses gulp...
I followed @tofumatt steps but can't replicate. I added some more console logs to investigate the behavior in more detail, but `useRefocus()` hook was always working for me as expected....
Despite previous assumptions, the spacing issue is not related to the joyride tour. Instead the spacing is caused by the last widget having a `min-height: 80vw` applied. https://github.com/google/site-kit-wp/blob/6551b8be34d798cc2eeb5b03934e53fd5ec325e1/assets/sass/widgets/_widget-context.scss#L25-L27 In reference...
The error comes from here: https://github.com/google/site-kit-wp/blob/610f6fd2ce5238eb4024d27f0335fc0e1311c381/assets/js/components/notifications/UserInputSettings.js#L67-L69 `isGatheringData` fetches a report from the API which then returns this error. So I think, inside `isGatheringData` we should verify if Analytics is connected....
@mohitwp Regarding you first questions about the UI and figma. I actually don't know. As I did not change the UI with this issue/pr. The component existed before and I...
@mohitwp > Issue > Under CTA banner description, it references 5 https://github.com/google/site-kit-wp/issues/5895#issuecomment-1348873878s, but we have only 3 questions currently. Probably, the user input questions changed from 5 to 3 question...
Unassigned me, since I did not start execution and got many other issues back from CR, that I have to work on.
@asvinb @aaemnnosttv We fixed the VRT font loading issue with #6324 So I think we can close this issue.
@aaemnnosttv what machine do you use? For me on mac M1 the VRT tests do not fail.