Julian Weiland

Results 55 comments of Julian Weiland

@VickyKoblinski thank you for this information. I actually don't know anything about how coverage works, so I will check this coverage provider setting. I'm not using nextjs but "pure" jest,...

@VickyKoblinski what do you mean with "but do you see a different number of line counts between the two coverage reports" Where can I see this?

@VickyKoblinski it looks like you are right about the reason for my problem. The Jest unit tests has a line coverage of 4/13 while storybook test-runner has 5/5 So jest...

So I tried to investigate my problem further. Looks like @VickyKoblinski is right with her assumption, the storybook test-runner and jest count the total numbers of lines (that need must...

@yannbf thank you for your help Yes I was able to setup a project. unfortunately its not that small. Its a fork of my real project. https://github.com/derweili/storybook-test-runner-coverage-demo You need to...

Related Issue on Google Fonts Repo. https://github.com/google/fonts/issues/2602 This is already fixed on Google Fonts.

I think this comes from here the InnerSlider Component. The Event listeners are create here: https://github.com/akiran/react-slick/blob/c923c95dce4b4efaf21e83f912c5055298a84be4/src/inner-slider.js#L727-L740 And passed directly to the div: https://github.com/akiran/react-slick/blob/c923c95dce4b4efaf21e83f912c5055298a84be4/src/inner-slider.js#L755-L759 To solve this warning, the component needs...

I implemented a solution in 94e4852e9afb224b43fa2497f68601565f567dfb checkout the [pot-task](/olefredrik/FoundationPress/tree/pot-task) branch Unfortunately the `gulp-wp-pot` requires node > 8 which does not comply with our current requirements (node > 6.11). I think...

@kLOsk I would prefer ES6 over ES5. What are the issuees with ES6?

**Please List the Following:** * OS & version: * Node version (node -v) [Node v6+ is required] : * FoundationPress version (see line 3 in package.json): * Foundation version (found...