Tomas Barton

Results 165 comments of Tomas Barton

Thanks for the PR. It looks ok, however we need to figure out a way how we won't break backwards compatibility for versions < 3.5.5. Adding by default configuration options...

@jkufro Thanks for quick response! Unfortunately this won't be enough. We need to have a valid ZooKeeper version string that can be evaluated for any installation method. Then the template...

> Is there any feedback on this PR that hasn't been addressed? @hdeadman Yes, there's still the backwards compatibility issue, that block this from merging. Variable `$::zookeeper::archive_version` won't be initialized...

What is the output of `dpkg --get-selections | grep -v deinstall | grep zookeeper`? It looks like in Ubuntu 16.04 the "service package" `zookeeperd` [contains "old" sysvinit](http://packages.ubuntu.com/xenial/all/zookeeperd/filelist) script. Which would...

That's quite strange. Which version of `puppet-zookeeper` and Puppet do you use?

@markcassidy What is the output of `facter -y operatingsystemmajrelease`? Just to be sure, could you also post `facter -y | grep operating`?

I suspect this might be a type issue, which were heavily changed in Puppet 4. But from your code it seems that `cdhver` should be parsed as a String which...

@tibers Any PRs are welcomed. Preferably in smaller chunks (each feature on PR). - RPMs: If the package is not provided by the distribution it should be ok. There seems...

Well the question is whether CentOS will include official ZooKeeper support or not. Cloudera is a 3rd party repository and not everyone must be fine with that. Currently we support...

Well basically this is the same problem as we're discussing in #18. I've written some sort of solution in 8f2477ccac27dea7a8f94129325d0dd26dd235df but it didn't seem to be consistent enough (I can't...