Artem Derevnjuk

Results 21 comments of Artem Derevnjuk

@B4nan right, this is an example for PG. However, this works well in MySQL https://dev.mysql.com/doc/refman/8.0/en/delete.html. I can't say for sure about SQLlite and MariaDB

No issues have been encountered while testing this with v5.0.0-rc.0, especially when we speak about the main functionality. However, I have noticed you changed the `fork` method signature, which might...

@B4nan thanks for the feedback) > What is qb? Is that third QB instance? I suppose this is just a typo. Anyway, it has been fixed by the last commit...

@B4nan I have added a few more tests (4e837db). Unfortunately, you are right. We should somehow override aliases once they have been used to build some clauses (e.g. join, where,...

@B4nan this is how one of the options. Anyway, I will check out if we have another option that does not imply a significant reworking of `CriteriaNode` and etc.

@B4nan Sorry for the delay) It is not possible easily to remap/override aliases (BTW neither `knex` nor `typeorm` does this). It may require rewriting the whole logic of `QueryBuilder` by...

@B4nan your comments are resolved including LGTM.com reported issue

@B4nan I hope so, but I can't do this without your help 😄

Any updates? Why don't easily extend the naming strategy by adding a method to retrieve a column name for embedded fields?

> must use @Inject decorator for that (on property). That's not exactly true. Even if you use a decorator on the property, it will raise the same exception. > The...