Mark Scherer comments

Results 870 comments of


                                            Mark Scherer

Bump up Cake dependencies versions in split packages.

Was this supposed to be merged without the release? As is, it seems to fail in CI. I guess we would need `@RC` appending for now

6.0: Remove all `_` prefixes from method names

@markstory Shall we go ahead and merge those before they become conflicting?

6.0: Remove all `_` prefixes from method names

Are we sure that we can safely use rector here and having concrete rules per method? Then I say this is simple enough as automation to warrant the cleanup for...

6.0: Remove all `_` prefixes from method names

I think we should instead use rector and create the rules and then just apply those on the code base. This way we know they work and the users can...

Paginate on collections (non DB)

I guess the interest here is low, I keep it as app specific then for now.

Add rector to CI

The config linked in the ticket almost at the bottom. Those are currently green for 5.next

Attachment Japanese filename will be unexpected automatically.

@T-Kisaku Do you want to make a PR with the suggested fix?

When executing a subcommand, can't the plugin name be camelCase?

Afaik you dont even need the plugin name at all. my_command mysubcommand should suffice, see --help for details.

When executing a subcommand, can't the plugin name be camelCase?

I guess we can close this as works-for-me?

When executing a subcommand, can't the plugin name be camelCase?

The opposite should be the case: By default CLI commands are always underscored, so having the camelCase support seems weird and inconsistent. It could still work but probably should not...