Mark Scherer

Results 859 comments of Mark Scherer
trafficstars

I merged https://github.com/cakephp/cakephp/pull/18721 changes into 5.next So if you rebase should be on latest changes then.

Error: Ignored error pattern #^Comparison operation "\>" between \(int\\|Redis\|false\) and 0 results in an error\.$# in path /home/runner/work/cakephp/cakephp/src/Cache/Engine/RedisEngine.php was not matched in reported errors. Error: Ignored error pattern #^Comparison operation...

I wonder what those test fails are @markstory can maybe sign off.

@nicosp If you are happy with it we can move forward now.

I am also so much looking forward to this. Was kinda hoping this comes with v2. The usefulness in psalm is unmatched so far. > And then you can safely...

Yes, thats a problem in PHPStan as it doesnt bind to a specific "version", so different PHP versions can cause this, but IMO shouldnt. But in general unrelated to the...

https://github.com/cakephp/cakephp/pull/18216 merged

for now I would mainly recommend enforcing a space around the arrow on the same line: ```php ->where(fn (QueryExpression $exp)=> $exp->between( ``` looks quite bad and should be ```php ->where(fn...

@nicosp Phinx is now being separated standalone. To also port this into CakePHP (Migrations), this would also need a 2nd PR to https://github.com/cakephp/migrations