Derek Su comments

Results 1074 comments of


                                            Derek Su

[IMPROVEMENT] CI validates conventional commits

All are merged.

fix(deps): update patch digest dependencies (v1.6.x)

@mantissahz Can you help resolve the conflicts? Thank you.

feat: v2 data engine live upgrade

@coderabbitai pause

feat: v2 data engine live upgrade

Close the PoC PR. @PhanLe1010 will address the live upgrade.

feat(spdk): Support changing volume size

Need to update the function. `cliAPIVersion` is always 0 for v2 volume, so skip the check. ``` func IsValidForExpansion(engine *longhorn.Engine, cliAPIVersion, imAPIVersion int) (bool, error) { if engine.Status.IsExpanding { return...

[IMPROVEMENT] Schedule at least one replica locally when locality is `best-effort`

Thanks @bachmanity1. We will review your PR soon. I've added you to the developer group. Could you help update the pre-check list https://github.com/longhorn/longhorn/issues/11007#issuecomment-2959125511? Feel free to let me know if...

[IMPROVEMENT] Schedule at least one replica locally when locality is `best-effort`

@bachmanity1 Is everything ready? If YES, you can update the status of `Longhorn Sprint` to `Ready For Testing`. Thank you.

[IMPROVEMENT] Schedule at least one replica locally when locality is `best-effort`

> Hi [@derekbit](https://github.com/derekbit), yes, it's ready for testing, but I don't think I have the rights to update the ticket status. I can't move tickets in the Kanban board. Thank...

[IMPROVEMENT] Schedule at least one replica locally when locality is `best-effort`

> [@chriscchien](https://github.com/chriscchien) it seems like there was something off with my longhorn installation. After deleting and reinstalling longhorn I'm now able to reproduce same results as described by you. >...

[IMPROVEMENT] Schedule at least one replica locally when locality is `best-effort`

> > Observed the same behavior in master-head and v1.9.0. > > ``` > > pvc-aaa26271-a7b4-4698-b62f-693c4499a42a v1 2147483648 0s > > pvc-aaa26271-a7b4-4698-b62f-693c4499a42a v1 2147483648 0s > > pvc-aaa26271-a7b4-4698-b62f-693c4499a42a v1 creating...