Derek Su

Results 1074 comments of Derek Su

Hello @hookak Could you help update the go.mod? Thank you.

@hookak Could you help to resolve the conflicts? The PR is ready to merge. Thank you.

Hello @hookak, build failed, can you help check it? Thanks.

> Could you review this one first? [longhorn/longhorn-instance-manager#1020](https://github.com/longhorn/longhorn-instance-manager/pull/1020) The instance manager needs to update the field name as well due to the rename of `AppliedRebuildingMBps`. @hookak LGTM and merged. Thank...

I'm fine with the sleep method. Another idea for reference is combining [EventSinkImpl](https://pkg.go.dev/k8s.io/client-go/tools/events#EventSinkImpl) with `WaitGroup` and make the flush period not fixed. Not sure if this can work :p ```...

> I think the goal of this ticket should be to document a KB article workaround to get rid of the annoying logs. > > To automatically cleanup, I think...

Can you help rebase the commit and ~~update the README.md~~ as well? Thank you.

@meln5674 Sorry, I missed the README.md is updated. In general, LGTM. BTW, it would be nice if you would be able to add an example and a test for the...