Derek Su

Results 1074 comments of Derek Su

@ejweber Could you help review the PR? Thank you.

> Hi @c3y1huang , @derekbit , > > Current retain parameter [disabled logic](https://github.com/a110605/longhorn-ui/blob/17e03c942267eb4522f95a3cd639ecd83004c628/src/routes/recurringJob/CreateRecurringJob.js#L321) is when in edit mode or recurring task is `snapshot-cleanup` or `filesystem-trim`. > > Are we sure...

> So that means we don't need to do any changes as the behavior is expected? But, why is the `Backup` recurring job's `Retain` greyed out in the user's figure?...

@houhoucoop remember to update `Sprint` field. Thank you. ![image](https://github.com/user-attachments/assets/93fcdcda-51ed-4c77-82fa-6318ea4a5e67)

As I mentioned in https://github.com/longhorn/longhorn/issues/8803#issuecomment-2192856444, the PR only adds the labels to webhook but doesn't handle the deletion. Could you help clear up my confusion?

> I hope so. This PR (and [longhorn/longhorn#8804](https://github.com/longhorn/longhorn/pull/8804) in longhorn) just add the new selector labels. Should make no difference to normal operation. After it is committed, then I can...

The check is enforced when starting the Longhorn Manager daemon. If any condition fails, the Longhorn Manager will enter a loop of Starting and CrashLoopBackOff. For users who only require...

cc @ChanYiLin for helping review it if having time. Thank you.