Emanuel Denzel

Results 8 comments of Emanuel Denzel

Is there any decision on this issue, if this will be implemented in geordi?

@andyw8 @koic Can one of you have another review for this PR or is it already ready for a merge to master? Thanks!

@jsolas Do you already have started with implementing this cop or do you have time capacities in the near future for it? Otherwise I can take care about it. @andyw8...

@koic Any chance this PR can be reviewed and merged to master? If there is anything I can help you or @fatkodima to finish the PR just let me know....

Thanks @koic & @fatkodima 💯

Just to ensure everyone is on the same page: - Calling `request.session.id` does not load the session. In case a previous session exists `Rack::Sesssion` will load the session in https://github.com/rack/rack-session/blob/v2.0.0/lib/rack/session/cookie.rb#L213....

> Don't see how this works when the asset is a binary file? If we're assuming ASCII-8BIT, what happens when you try to read a PNG? @dhh Do you think...

Thanks @nevans, I can prepare a PoC PR for this issue. I will take approx. 6 weeks until I can start with this task (just for a rough timeline).