Patrik Ragnarsson

Support `Forwarded` header

1

See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded Since Rack 3 (https://github.com/rack/rack/pull/1834) the `Forwarded` is supported (and [preferred](https://github.com/rack/rack/blob/v3.0.10/lib/rack/request.rb#L20-L44)). Sinatra does not make use of this: https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/lib/sinatra/base.rb#L63-L65 Which one to prefer should probably be exposed to the...

[BUG]: `faraday-multipart` warning always printed

2

### What happened? Since https://github.com/octokit/octokit.rb/pull/1688 (https://github.com/octokit/octokit.rb/commit/cff7c55bffc312f6ee3c9ceedb8b7929f07cef1d) octokit.rb always prints a warning if it can't load `faraday-multipart`. From the warning, it sounds like I don't need `faraday-multipart` unless I upload licenses....

List routes

1

Be able to list the routes defined by a Rack/Sinatra application.

Remove `Sinatra::Cookies` (sinatra-contrib helper)?

1

This code: https://github.com/sinatra/sinatra/blob/v4.0.0/sinatra-contrib/lib/sinatra/cookies.rb Or give it some love? Do we need to do this? Isn't Rack doing this? https://github.com/sinatra/sinatra/blob/b626e2d82c23b4fde0b51782fd32ca27ccde1d1a/sinatra-contrib/lib/sinatra/cookies.rb#L311-L332

Test `IntegrationTest#test_with_puma_logs_once_in_development_mode_0` failed with jruby

1

From https://github.com/sinatra/sinatra/actions/runs/9880366465/job/27288730224#step:5:26 `jruby 9.4.8.0 (3.1.4) 2024-07-02 4d41e55a67 OpenJDK 64-Bit Server VM 11.0.23+9 on 11.0.23+9 +jit [x86_64-linux]` ``` 1) Error: IntegrationTest#test_with_puma_logs_once_in_development_mode_0: Net::HTTPBadResponse: wrong status line: "x-content-type-options: nosniff" /home/runner/.rubies/jruby-9.4.8.0/lib/ruby/stdlib/net/http/response.rb:43:in `read_status_line' /home/runner/.rubies/jruby-9.4.8.0/lib/ruby/stdlib/net/http/response.rb:31:in `read_new'...

Can we stop deleting the `content-length` header here? It has been problematic in the past: see https://github.com/sinatra/sinatra/issues/2019 and all the linked history https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/lib/sinatra/base.rb#L290-L304 It was introduced so the `content-length` header...

Looks like they all will expire Aug 1 if we don't do anything. I ran this $ ruby examples/puma/client-certs/generate_client_test.rb Key length: 2048 sign_algorithm: OpenSSL::Digest::SHA256 Normal cert dates: 2024-07-01 00:00:00 +0000...

Problem with Zeitwerk 2.7.0+

1

Using Zeitwerk 2.6.18 (last version before 2.7.0), we could start this app https://github.com/sinatra/sinatra/blob/973c936319af9132d7ab2f60985e359d0c75c93e/test/integration/zeitwerk_app.rb#L1-L8 Like this ``` root@9bfe2a21d749:/app# ruby ./test/integration/zeitwerk_app.rb -p 0 -s puma /usr/local/lib/ruby/3.3.0/bundled_gems.rb:75: warning: Rack::Logger is deprecated and will...

Reported at https://github.com/puma/puma/pull/3485#issuecomment-2346732479 See log at https://github.com/MSP-Greg/sinatra/actions/runs/10834167576/job/30062684301#step:5:26 ``` starting [2024-09-12 15:40:50] INFO WEBrick 1.8.1 [2024-09-12 15:40:50] INFO ruby 3.4.0 (2024-09-09) [x86_64-linux] == Sinatra (v4.0.0) has taken the stage on 5033...