Dennis Klein
Dennis Klein
@fuhlig1 Not tested yet. What do you think? ```cpp const char* PixelGeo::getModuleName(Int_t m) { const auto formatStr = "Pixel{}"; const auto moduleNumber = m + 1; // shifted by 1...
hm, doesn't work with just `std::begin`, this works https://godbolt.org/z/xe9zaYMcM (C++17: https://godbolt.org/z/xbavrcqsK) but the `resize(0)` does unnecessary work...
https://godbolt.org/z/1r1EsTGrs: ```cpp const char* getModuleNameCpp17(std::string& modName, int m) { constexpr auto formatStr = "Pixel{}"; const auto moduleNumber = m + 1; // shifted by 1 to accomodate counting starting at...
@coderabbitai read fairroot/base/sim/FairVolumeList[.h|.cxx] and generate additional unit tests for the file tests/base/sim/test_FairVolumeList.cxx.
@coderabbitai read the git commits in this PR and suggest improvements on the commit msg text for each one. Make sure to state the reasons for your change suggestions.
@coderabbitai use origin/dev as base branch
@coderabbitai now do the same also for each commit msg body if present.
@coderabbitai read the file CHANGELOG.md and generate additional changelog entries for the important user-facing changes in this PR.
@coderabbitai give it another shot, try to keep each point slightly shorter and focus on important user-facing API changes only
@coderabbitai Go through the git commits in this PR (origin/dev is base branch) and evaluate the commit granularity. Make suggestions which commits to split or merge based on whether they...