Dennis Klein

Results 122 comments of Dennis Klein

I just encountered the same issue. Turns out brew's compiler wrapper script filters out any `-march` flags now, unless the formula opts in to not remove it. See https://github.com/Homebrew/brew/commit/0404da7ba7d22379b236c503d6a87746a848776c. Adding...

> Got some audit failure, but the build is successful > > ``` > vc: > * No `cpuid` instruction detected. vc should not use `ENV.runtime_cpu_detection`. > ``` That seems...

I guess, if you teach this code to also include `libVc.a` in the set of checked files, the audit will succeed: https://github.com/Homebrew/brew/blob/36d14ae49cc4cd410b0b77e7d4f01e1836fd3be8/Library/Homebrew/formula_cellar_checks.rb#L312-L316

Now it is green: https://github.com/FairRootGroup/FairMQ/actions/runs/6148931619/job/16683739521, it will be merged to master on next release. Thx @ChristianTackeGSI for the PRs!

Just collecting what shows up so far: ``` Common/Field/src/MagFieldFact.cxx:30:73: warning: 'FairFieldFactory::fCreator' is deprecated [-Wdeprecated-declarations] 30 | MagFieldFact::MagFieldFact() : FairFieldFactory(), mFieldPar(nullptr) { fCreator = this; } | ^~~~~~~~ In file included...

> Have a way to run tests with graphics. On a system with X11 graphics you could use [Xvfb](https://www.x.org/releases/X11R7.6/doc/man/man1/Xvfb.1.xhtml). It ships with a command-line tool `xvfb-run`, so you can run...

> I would merely like to make sure that the ED does not crash when opened. > That's the minimum we can check. Then we would need at least a...

Please rebase on current `dev`, thx!

> ```cpp > return dynamic_cast (this->fMap->at(n)); > ``` :nerd_face: adventurous, but fine with me. However, you should not unconditionally dereference `fMap`.

> I do not understand the rationale behind the separate `Init()` method. AFAICS, it is a two-fold answer: 1. Scheduling/timing - the framework controls **when** initialization happens 2. There is...