Denis Zykov

Results 121 comments of Denis Zykov

You should Close() and Dispose() WebSockets on both ends. No doing this lead to resource leaks. This probably cause SslStream malfunction (too many opened streams).

Hello, James! Unfortunately JS doesn't have native (U)Int64, so currently there is no support for numbers larger than Int53 (integer part of Double). This is UI limitation and will be...

Hmm, writing should ends with `writer.CloseAsync()`. There is a huge warning message about this in logger. Do you provided you logger implementation in `WSListenerOptions`? Also all sync method (like `writer.Write()`)...

`async void` - this create _untrackable_ async method. No one knows when its ends. This will cause parallel calls to `WriteDynamicAsync()` and _There is an ongoing message that is being...

I have updated _readme.md_. Previously, `Close()` was not required. Now synchronous methods are prohibited and it is necessary to finish writing to the stream with `CloseAsync()`.

> Can not access a closed Stream at the inner bracket close. Can you provide full exception message and stack trace?

`StreamWriter` cached data, so you need to call `FlushAsync()` on `StreamWriter` after you finished writing. If you don't, it will flush on `Dispose()`, which is right after `CloseAsync()`. This cause...

Also any 'Write/Read/Flush' synchronous calls completely destroy the performance of the application. They will block _Thread Pool_ threads and cause _thread starvation_. So you need to make sure no explicit/implicit...

Maybe it is better to make `Out` a `Subject` and infinite async method polling this subject and writes messages? ``` public static async Task WriteMessageAsync(WebSocket ws, IObservable messages) { while(ws.IsConnected)...

> my best approximation to the WriteStringAsync code does not seem to work correctly Hi @weweilep! Could you provide your version of WriteBytesAsync for review?