Botond Dénes

> > [test_database_with_data_in_sstables_is_a_mutation_source_reverse_reader_conversion_cg0](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/13902/testReport/junit/boost/database_test/test_database_with_data_in_sstables_is_a_mutation_source_reverse_reader_conversion_cg0) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+test_database_with_data_in_sstables_is_a_mutation_source_reverse_reader_conversion_cg0) > > #21983 I changed two python files related to debugging coredumps and I hit this error in a C++ unit test twice. :/

@scylladb/scylla-maint ping for merge.

@scylladb/scylla-maint ping for merge.

New in v3: * Drop the flat_hash_map match relaxing. I don't remember why I included it anymore.

> * [cqlpy.cassandra_tests/validation/entities/uf_types_test.dev.1](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/15191/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___cqlpy_cassandra_tests_validation_entities_uf_types_test_dev_1) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+cqlpy.cassandra_tests/validation/entities/uf_types_test.dev.1) > > * [cqlpy.cassandra_tests/validation/entities/uf_types_test.dev.2](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/15191/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___cqlpy_cassandra_tests_validation_entities_uf_types_test_dev_2) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+cqlpy.cassandra_tests/validation/entities/uf_types_test.dev.2) > > * [cqlpy.cassandra_tests/validation/entities/uf_types_test.dev.3](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/15191/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___cqlpy_cassandra_tests_validation_entities_uf_types_test_dev_3) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+cqlpy.cassandra_tests/validation/entities/uf_types_test.dev.3) > > * [cqlpy.cassandra_tests/validation/entities/uf_types_test.release.1](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/15191/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___cqlpy_cassandra_tests_validation_entities_uf_types_test_release_1) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+cqlpy.cassandra_tests/validation/entities/uf_types_test.release.1) > > * [cqlpy.cassandra_tests/validation/entities/uf_types_test.release.2](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/15191/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___cqlpy_cassandra_tests_validation_entities_uf_types_test_release_2) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+cqlpy.cassandra_tests/validation/entities/uf_types_test.release.2) > > * [cqlpy.cassandra_tests/validation/entities/uf_types_test.release.3](https://jenkins.scylladb.com//job/scylla-master/job/scylla-ci/15191/testReport/junit/%28root%29/non-boost%20tests/Tests___Unit_Tests___cqlpy_cassandra_tests_validation_entities_uf_types_test_release_3) [🔍](https://github.com/scylladb/scylladb/issues?q=is:issue+is:open+cqlpy.cassandra_tests/validation/entities/uf_types_test.release.3) https://github.com/scylladb/scylladb/issues/22799

> @roydahan told me we have an SCT with mixed shards which we can run on this patch perhaps, to see the impact. We are using https://github.com/scylladb/scylla-cluster-tests/pull/8435 (by @Deexie) to...

This PR was tested by @Deexie via https://github.com/scylladb/scylla-cluster-tests/pull/8435. This test runs the following scenario: * Create a cluster with two 16 shard nodes. * Write data. * Add a new...

Tests are failing because using the too large repair buffer as the multishard reader's buffer size triggers the semaphore's kill limit.

New in v2: * Set buffer size to min(repair_buffer_size, 1MB), this should be a better mid-ground. * Fixed buffer size accounting in shard buffer, use sum of fragment sizes, instead...

TODO: re-run the reporoducer with the new version, after CI passes.