Botond Dénes
Botond Dénes
New in v2: * rebased * `utils::fragmented_temporary_buffer` is changed to use `utils::small_vector` instead of `std::vector`
> > * `utils::fragmented_temporary_buffer` is changed to use `utils::small_vector` instead of `std::vector` > > I saw regression with this change in this benchmark: [tgrabiec/scylla-enterprise@d505025](https://github.com/tgrabiec/scylla-enterprise/commit/d505025958af69ba9677453325af7554184b2aa1) > > Can you post your...
New in v3: drop the second patch (making fragmented buffer use small vector) as Tomek found that it causes perf regressions.
New in v2: * Drop the `--select`, `--what` and `--allow-filtering` params, replace with `-q|--query` instead, which passes a complete query on the command-line. Still kept `--query-file` as a backup in...
New in v3: * Drop `to_json_value()` and changes to `to_json_string()`, add `to_json_type()` instead. * Drop changes to `temp_dir` and related changes to `cql_test_env`, use `TEMPDIR` env variable instead.
CI failure related to this PR.
New in v4: * Update the test to make it pass in debug mode too.
Dequeued, test failed on aarch64/debug: ``` cql = scylla_path = '/jenkins/workspace/scylla-master/next/scylla/build/Debug/scylla' scylla_data_dir = '/scylladir/testlog/aarch64/debug/scylla-368/data' def test_scylla_sstable_query_temp_dir(cql, scylla_path, scylla_data_dir): """Check that TEMPDIR environment variable is respected. This is very hard to...
New in v5: * Don't assume node has `/dev/null`, create a temporary file instead.
> > ``` > > * Don't assume node has `/dev/null`, create a temporary file instead. > > ``` > > What do you mean a node "has /dev/null"? It's...