Botond Dénes
Botond Dénes
I think that if there are no users of this functionality we should remove it: in a few years no one will remember what this is and we won't dare...
Thanks for expressing interest in this @paulvictor. Well if there are (would-be) users than we can definitely keep this. I'll review this PR and will try to dig up my...
Affected versions: 5.1+.
While I agree that these tools should be tested, I'm not sure dtest and SCT are the right place for this. For one the tools we currently have don't use...
> There are existing tests in dtest (and probably sct) - we need to migrate them over to this tools if they are going to replace the existing java tools...
We are quite close. To replace sstabledump in tests with scylla-sstable, we need https://github.com/scylladb/scylladb/issues/10126 first.
Because we have built-in defenses against an attempt to fast-forward sstable readers to smaller position than the current form (an assert), when cross-referencing the index with the data file, I...
New in v2: * Fold separate validation of first entry into loop, separation no longer necessary. * In-line reader validation lambda into call-site. * Don't pass temporary partition-range to reader.
This is basically a complete rewrite of the entire PR. The previous code was completely discarded as a different approach was needed. New in v3: * Add low-level validator which...
TODO: I need to think of a way to test this. Maybe mix index/data from two different (but similar) sstables. But I'd like a review round first. In case the...