Botond Dénes
Botond Dénes
@nodep please add "Fixes scylladb/scylladb#20060" to the cover-letter. https://github.com/scylladb/scylladb/issues/20060 is about a tablet migration racing with truncate, which will be fixed by this PR.
The real bug here is that this feature doesn't have a test ;).
> @nuivall why not request anybody from Cluster team to review this? Feel free to send a patch against .github/CODEOWNERS and add yourself for all folders/files that your team owns....
Dup of https://github.com/scylladb/scylladb/issues/20060.
> By the way, this is a general problem not only specific to tests: Sometimes you send some sort of preparatory or cleanup patch which is pointless to backport on...
> to see if it includes --no-use-cmake. after this change lands. we will remove the BUILD_WITH_CMAKEparameter, and use cmake as long asconfigure.pysupports--no-use-cmake` option. backticks are off in the cover letter.
We can make an exception for this PR, we can merge to 6.0 and then I will do one last 6.0 -> 2024.2 merge.
Is this PR ready to merge? I see some review comments from @tgrabiec. Were those addressed?
@annastuchlik please resolve the conflicts.
> @denesb I've fixed it directly on GitHub. Otherwise, I couldn't edit this PR (or I didn't know how to) due to some problems with write permissions. If it's against...