Botond Dénes
Botond Dénes
If I understand correctly, the setting of expected children is needed just for this one if: https://github.com/scylladb/scylladb/blob/d81e0d0754b937937ab5b86c57f5fb2ee1b0b925/tasks/task_manager.cc#L143-L148 Can we invert the order of checks here? If we know that we...
> > If I understand correctly, the setting of expected children is needed just for this one if: > > https://github.com/scylladb/scylladb/blob/d81e0d0754b937937ab5b86c57f5fb2ee1b0b925/tasks/task_manager.cc#L143-L148 > > > > Can we invert the order...
> To reproduce this issue, it involves simulating the failure of writing indexes, and the cluster should have no less than 2 replicas and 2 nodes. After my study and...
> > > To reproduce this issue, it involves simulating the failure of writing indexes, and the cluster should have no less than 2 replicas and 2 nodes. After my...
> a function that can simulate asynchronous GSI writing failure I recommend using error-injection for this. Add an error-injection to the code-path which propagates the update. When this error-injection is...
@libo-sober cover letter needs updating, it still talks about the old test.
``` manager = @pytest.mark.asyncio async def test_mv_loss_attrs_exception(manager: ManagerClient) -> None: node_count = 2 config = {'error_injections_at_startup': ['never_finish_remote_view_updates'], 'enable_tablets': True} servers = await manager.servers_add(node_count, config=config) cql, _ = await manager.get_ready_cql(servers) await...
We already have a `querier_cache::stop()` method, which is called from `replica::database::stop()`: https://github.com/scylladb/scylladb/blob/b3d951517d21e566866a070992fc7a1342ee6b43/replica/database.cc#L2367-L2412 I notice it is called after `sstables::sstable_manager::stop()` (both user and system), maybe this is the wrong order?