Botond Dénes
Botond Dénes
Ok, we still need a blessing from @avikivity w.r.t. the proposed deprecation schedule.
No, master is the correct target. This PR seems to contain commits from next, please drop them.
> v4: redo per https://github.com/scylladb/scylladb/blob/master/docs/dev/maintainer.md#updating-submodule-references [@tchaikov] When submitting a PR for the submodule change, you need to checkout the `master` branch, not the `next` branch (step 1). This is why...
> The referenced section literally starts with the following instruction: > > > Check out the `next` branch and synchronize it using `git pull` > > That's why my v4...
> The maintainer documentation is aimed at maintainers for whom committing the submodule update to next is the correct procedure. This is not correct when one wants to open a...
> So we add 0.25% overhead. Hard to judge if it's worthwhile. @avikivity I think the gain is much higher than 0.25% here. We need to reduce the bar of...
> @denesb can you tell me, how did you figure out performance differences for my patch (or any patch)? Sub 1% precision looks amazing to me, how did you do...
No matter how much time you spend trying to decipher those lambda names, you won't be able to make sense of one which is big enough to fill your screen....
I am not familiar with the SCT code, but the description looks good to me. Did you get a chance to run the test? How do the numbers look?
@pehala please review.